]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dm-verity: remove log message with shash driver name
authorEric Biggers <ebiggers@kernel.org>
Tue, 14 Oct 2025 21:16:54 +0000 (14:16 -0700)
committerMikulas Patocka <mpatocka@redhat.com>
Mon, 20 Oct 2025 13:47:17 +0000 (15:47 +0200)
I added this log message in commit bbf6a566920e ("dm verity: log the
hash algorithm implementation"), to help people debug issues where they
forgot to enable the architecture-optimized SHA-256 code in their
kconfig or accidentally enabled a slow hardware offload driver (such as
QCE) that overrode the faster CPU-accelerated code.  However:

- The crypto layer now always enables the architecture-optimized SHA-1,
  SHA-256, and SHA-512 code.  Moreover, for simplicity the driver name
  is now fixed at "sha1-lib", "sha256-lib", etc.

- dm-verity now uses crypto_shash instead of crypto_ahash, preventing
  the mistake of accidentally using a slow driver such as QCE.

Therefore, this log message generally no longer provides useful
information.  Remove it.

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
drivers/md/dm-verity-target.c

index 66a00a8ccb398b6bcd9cfe09ab9bbf7f94f29b1c..20ddf560d22e301ecb89c293c1f07e44b54bf0cb 100644 (file)
@@ -1252,7 +1252,6 @@ static int verity_setup_hash_alg(struct dm_verity *v, const char *alg_name)
        }
        v->shash_tfm = shash;
        v->digest_size = crypto_shash_digestsize(shash);
-       DMINFO("%s using \"%s\"", alg_name, crypto_shash_driver_name(shash));
        if ((1 << v->hash_dev_block_bits) < v->digest_size * 2) {
                ti->error = "Digest size too big";
                return -EINVAL;