]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iommufd/fault: Destroy response and mutex in iommufd_fault_destroy()
authorNicolin Chen <nicolinc@nvidia.com>
Wed, 15 Jan 2025 06:55:59 +0000 (22:55 -0800)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 16 Jan 2025 20:40:33 +0000 (16:40 -0400)
Both were missing in the initial patch.

Fixes: 07838f7fd529 ("iommufd: Add iommufd fault object")
Link: https://patch.msgid.link/r/bc8bb13e215af27e62ee51bdba3648dd4ed2dce3.1736923732.git.nicolinc@nvidia.com
Cc: stable@vger.kernel.org
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/fault.c

index 1fe804e28a8663838e6de855775f261a43d0c915..685510224d05506707fe3d0ca3e960c0a9d3bf3f 100644 (file)
@@ -213,6 +213,7 @@ void iommufd_fault_destroy(struct iommufd_object *obj)
 {
        struct iommufd_fault *fault = container_of(obj, struct iommufd_fault, obj);
        struct iopf_group *group, *next;
+       unsigned long index;
 
        /*
         * The iommufd object's reference count is zero at this point.
@@ -225,6 +226,13 @@ void iommufd_fault_destroy(struct iommufd_object *obj)
                iopf_group_response(group, IOMMU_PAGE_RESP_INVALID);
                iopf_free_group(group);
        }
+       xa_for_each(&fault->response, index, group) {
+               xa_erase(&fault->response, index);
+               iopf_group_response(group, IOMMU_PAGE_RESP_INVALID);
+               iopf_free_group(group);
+       }
+       xa_destroy(&fault->response);
+       mutex_destroy(&fault->mutex);
 }
 
 static void iommufd_compose_fault_message(struct iommu_fault *fault,