]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: brcmsmac: add gain range check to wlc_phy_iqcal_gainparams_nphy()
authorDmitry Antipov <dmantipov@yandex.ru>
Tue, 10 Dec 2024 07:04:41 +0000 (10:04 +0300)
committerKalle Valo <kvalo@kernel.org>
Fri, 13 Dec 2024 12:54:42 +0000 (14:54 +0200)
In 'wlc_phy_iqcal_gainparams_nphy()', add gain range check to WARN()
instead of possible out-of-bounds 'tbl_iqcal_gainparams_nphy' access.
Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241210070441.836362-1-dmantipov@yandex.ru
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c

index d69879e1bd870c91008d56b255e041c62a7f20e3..d362c4337616b44afbca5d109029183ca1bc643b 100644 (file)
@@ -23423,6 +23423,9 @@ wlc_phy_iqcal_gainparams_nphy(struct brcms_phy *pi, u16 core_no,
                                break;
                }
 
+               if (WARN_ON(k == NPHY_IQCAL_NUMGAINS))
+                       return;
+
                params->txgm = tbl_iqcal_gainparams_nphy[band_idx][k][1];
                params->pga = tbl_iqcal_gainparams_nphy[band_idx][k][2];
                params->pad = tbl_iqcal_gainparams_nphy[band_idx][k][3];