LINEMAP_POSITION_FOR_COLUMN had the exact same effect as linemap_position_for_column...

LINEMAP_POSITION_FOR_COLUMN had the exact same effect as
linemap_position_for_column, removed it and updated users
to use linemap_position_for_column instead

        libcpp/ChangeLog
	* include/line-map.h (LINEMAP_POSITION_FOR_COLUMN): Remove.
	Update all users to use linemap_position_for_column instead.

        gcc/go/ChangeLog
	* gofrontend/lex.cc (Lex::location): Update to use
	linemap_position_for_column instead.
        (Lex::earlier_location): Likewise.

From-SVN: r177768

diff --git a/gcc/go/ChangeLog b/gcc/go/ChangeLog
index 549bc03712f7c2980857aa0f35b646b0629bd51c..269d89a2b6cf2ce6a0cd093e36057b1a8e3d24a4 100644 (file)
--- a/gcc/go/ChangeLog
+++ b/gcc/go/ChangeLog
@@ -1,3 +1,9 @@
+2011-08-15  Gabriel Charette  <gchare@google.com>
+
+       * gofrontend/lex.cc (Lex::location): Update to use
+       linemap_position_for_column instead.
+       (Lex::earlier_location): Likewise.
+
 2011-08-08  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 
        * Make-lang.in (gccgo$(exeext)): Add $(EXTRA_GCC_LIBS).

diff --git a/gcc/go/gofrontend/lex.cc b/gcc/go/gofrontend/lex.cc
index 9f26911a16c87e7ca5b5b560a7e17ab2d7e0f647..167c7ddffc02973f23e0711e65af3e6691cfd23d 100644 (file)
--- a/gcc/go/gofrontend/lex.cc
+++ b/gcc/go/gofrontend/lex.cc
@@ -518,9 +518,7 @@ Lex::require_line()
 source_location
 Lex::location() const
 {
-  source_location location;
-  LINEMAP_POSITION_FOR_COLUMN(location, line_table, this->lineoff_ + 1);
-  return location;
+  return linemap_position_for_column (line_table, this->lineoff_ + 1);
 }
 
 // Get a location slightly before the current one.  This is used for
@@ -529,9 +527,7 @@ Lex::location() const
 source_location
 Lex::earlier_location(int chars) const
 {
-  source_location location;
-  LINEMAP_POSITION_FOR_COLUMN(location, line_table, this->lineoff_ + 1 - chars);
-  return location;
+  return linemap_position_for_column (line_table, this->lineoff_ + 1 - chars);
 }
 
 // Get the next token.

diff --git a/libcpp/ChangeLog b/libcpp/ChangeLog
index 1b224182368bcecbbe26fbd647861d792ae0e0b8..e136852231b2d1bc64817fe99dbb0d7b0b18ced5 100644 (file)
--- a/libcpp/ChangeLog
+++ b/libcpp/ChangeLog
@@ -1,3 +1,8 @@
+2011-08-15  Gabriel Charette  <gchare@google.com>
+
+       * include/line-map.h (LINEMAP_POSITION_FOR_COLUMN): Remove.
+       Update all users to use linemap_position_for_column instead.
+
 2011-07-28  Gabriel Charette  <gchare@google.com>
 
        * include/line-map.h (struct line_maps):

diff --git a/libcpp/directives-only.c b/libcpp/directives-only.c
index e19f80696141cff5031b3b2d1accdee5d04903a6..c6772afb83d83c077940fe10b0fae51e89c5dc8d 100644 (file)
--- a/libcpp/directives-only.c
+++ b/libcpp/directives-only.c
@@ -142,7 +142,7 @@ _cpp_preprocess_dir_only (cpp_reader *pfile,
            flags |= DO_LINE_COMMENT;
          else if (!(flags & DO_SPECIAL))
            /* Mark the position for possible error reporting. */
-           LINEMAP_POSITION_FOR_COLUMN (loc, pfile->line_table, col);
+           loc = linemap_position_for_column (pfile->line_table, col);
 
          break;
 

diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h
index f1d5bee801b98d5bfd0b10da94b7e27775c416f8..3c84035e95fd896ca38b8b89aed45fbd73dd88cd 100644 (file)
--- a/libcpp/include/line-map.h
+++ b/libcpp/include/line-map.h
@@ -165,23 +165,6 @@ extern const struct line_map *linemap_lookup
 /* Nonzero if the map is at the bottom of the include stack.  */
 #define MAIN_FILE_P(MAP) ((MAP)->included_from < 0)
 
-/* Set LOC to a source position that is the same line as the most recent
-   linemap_line_start, but with the specified TO_COLUMN column number.  */
-
-#define LINEMAP_POSITION_FOR_COLUMN(LOC, SET, TO_COLUMN) do { \
-  unsigned int to_column = (TO_COLUMN); \
-  struct line_maps *set = (SET); \
-  if (__builtin_expect (to_column >= set->max_column_hint, 0)) \
-    (LOC) = linemap_position_for_column (set, to_column); \
-  else { \
-    source_location r = set->highest_line; \
-    r = r + to_column; \
-    if (r >= set->highest_location) \
-      set->highest_location = r; \
-    (LOC) = r;                  \
-  }} while (0)
-    
-
 extern source_location
 linemap_position_for_column (struct line_maps *set, unsigned int to_column);
 

diff --git a/libcpp/lex.c b/libcpp/lex.c
index d29f36d436d7ce52a8e818b0d599917cb88d56cf..d460b98d5d22b242c85bd038b73183eecd853882 100644 (file)
--- a/libcpp/lex.c
+++ b/libcpp/lex.c
@@ -1975,8 +1975,8 @@ _cpp_lex_direct (cpp_reader *pfile)
     }
   c = *buffer->cur++;
 
-  LINEMAP_POSITION_FOR_COLUMN (result->src_loc, pfile->line_table,
-                              CPP_BUF_COLUMN (buffer, buffer->cur));
+  result->src_loc = linemap_position_for_column (pfile->line_table,
+                                                           CPP_BUF_COLUMN (buffer, buffer->cur));
 
   switch (c)
     {