]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Don't raise an error on retryable read in a BIO_s_dgram_pair()
authorMatt Caswell <matt@openssl.org>
Thu, 1 Dec 2022 14:16:02 +0000 (14:16 +0000)
committerHugo Landau <hlandau@openssl.org>
Wed, 22 Feb 2023 05:33:24 +0000 (05:33 +0000)
This results in spurious errors appearing on the queue in normal
operation, e.g. calling SSL_tick() with a QUIC connection will succeed,
but an error will end up on the queue anyway.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20030)

crypto/bio/bss_dgram_pair.c

index 3685d51f55d9947d8e1a900a7210fa902bfca229..b80fa62e48a7d03e95ba4ff5f767b27646729b57 100644 (file)
@@ -1066,12 +1066,10 @@ static int dgram_pair_recvmmsg(BIO *bio, BIO_MSG *msg,
                                    m->local, m->peer, 1);
         if (l < 0) {
             *num_processed = i;
-            if (i > 0) {
+            if (i > 0)
                 ret = 1;
-            } else {
-                ERR_raise(ERR_LIB_BIO, -l);
+            else
                 ret = 0;
-            }
             goto out;
         }