]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: mt9v032: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:14 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:23 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/mt9v032.c

index 302120ff125e0b42d9713b564c3ffd7fb0ea4030..9f4b4cb9853eae41cd1e0afb94ae7f78ea2acfc7 100644 (file)
@@ -1058,9 +1058,10 @@ static int mt9v032_probe(struct i2c_client *client)
        if (IS_ERR(mt9v032->regmap))
                return PTR_ERR(mt9v032->regmap);
 
-       mt9v032->clk = devm_clk_get(&client->dev, NULL);
+       mt9v032->clk = devm_v4l2_sensor_clk_get(&client->dev, NULL);
        if (IS_ERR(mt9v032->clk))
-               return PTR_ERR(mt9v032->clk);
+               return dev_err_probe(&client->dev, PTR_ERR(mt9v032->clk),
+                                    "failed to get the clock\n");
 
        mt9v032->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset",
                                                      GPIOD_OUT_HIGH);