libxfs: fix double free in libxfs_alloc_file_space

When porting the transaction alocation interface to userspace
(commit 9074815), I missed a change in libxfs_alloc_file_space() that
could lead to a double free of a transaction pointer in an error path.
Coverity spotted it, so fix it.

Coverity-id: 1362811
Signed-off-by: Dave Chinner <david@fromorbit.com>

diff --git a/libxfs/util.c b/libxfs/util.c
index 37941246eb5dc97acb513be216053dbd20f72595..90eaf41c8ea388a61bef7cd56509a4fe44d58aef 100644 (file)
--- a/libxfs/util.c
+++ b/libxfs/util.c
@@ -548,11 +548,7 @@ libxfs_alloc_file_space(
                 * Check for running out of space
                 */
                if (error) {
-                       /*
-                        * Free the transaction structure.
-                        */
                        ASSERT(error == -ENOSPC);
-                       xfs_trans_cancel(tp);
                        break;
                }
                xfs_trans_ijoin(tp, ip, 0);