net: stmmac: dwmac4: Fix the MTL_OP_MODE_*_MASK operation

In order to mask off the bits, we need to use the '~' operator to invert
all the bits of _MASK and clear them.

Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241107063637.2122726-3-leyfoon.tan@starfivetech.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c
index 22a044d93e172f6e667e6c3a8a0830304a38f232..0cb84a0041a4630428b607aa8435a5fb775d98b0 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c
@@ -274,7 +274,7 @@ static void dwmac4_dma_rx_chan_op_mode(struct stmmac_priv *priv,
        } else {
                pr_debug("GMAC: disable RX SF mode (threshold %d)\n", mode);
                mtl_rx_op &= ~MTL_OP_MODE_RSF;
-               mtl_rx_op &= MTL_OP_MODE_RTC_MASK;
+               mtl_rx_op &= ~MTL_OP_MODE_RTC_MASK;
                if (mode <= 32)
                        mtl_rx_op |= MTL_OP_MODE_RTC_32;
                else if (mode <= 64)
@@ -343,7 +343,7 @@ static void dwmac4_dma_tx_chan_op_mode(struct stmmac_priv *priv,
        } else {
                pr_debug("GMAC: disabling TX SF (threshold %d)\n", mode);
                mtl_tx_op &= ~MTL_OP_MODE_TSF;
-               mtl_tx_op &= MTL_OP_MODE_TTC_MASK;
+               mtl_tx_op &= ~MTL_OP_MODE_TTC_MASK;
                /* Set the transmit threshold */
                if (mode <= 32)
                        mtl_tx_op |= MTL_OP_MODE_TTC_32;