]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
net/sched: flower: add missing validation of TCA_FLOWER_FLAGS
authorDavide Caratti <dcaratti@redhat.com>
Tue, 11 Feb 2020 18:33:40 +0000 (19:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 15:36:09 +0000 (16:36 +0100)
[ Upstream commit e2debf0852c4d66ba1a8bde12869b196094c70a7 ]

unlike other classifiers that can be offloaded (i.e. users can set flags
like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of
netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry
to fl_policy.

Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sched/cls_flower.c

index 1879665e5a2bcd567d0a3926d329d7ccf8836f8f..80a5a6d503c8e6c200536dfa068820adc750829f 100644 (file)
@@ -445,6 +445,7 @@ static const struct nla_policy fl_policy[TCA_FLOWER_MAX + 1] = {
        [TCA_FLOWER_KEY_IP_TOS_MASK]    = { .type = NLA_U8 },
        [TCA_FLOWER_KEY_IP_TTL]         = { .type = NLA_U8 },
        [TCA_FLOWER_KEY_IP_TTL_MASK]    = { .type = NLA_U8 },
+       [TCA_FLOWER_FLAGS]              = { .type = NLA_U32 },
 };
 
 static void fl_set_key_val(struct nlattr **tb,