]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: imx: use prepare_transfer_hardware() for lpspi
authorGao Pan <pandy.gao@nxp.com>
Thu, 24 Nov 2016 11:04:44 +0000 (19:04 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 25 Nov 2016 13:04:41 +0000 (13:04 +0000)
The old driver enable clk in fsl_lpspi_prepare_message() and
disable clk in fsl_lpspi_unprepare_message().

Rather than doing this per message it's a bit better to do it
in prepare_transfer_hardware(), that way if there's a sequence
of messages queued one after another we don't turn the clock on
and off all the time.

Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-lpspi.c

index bcb7b284d2f277665f7db2bf5d3d5f55694fe072..d7ce32aa083b993c9abd81ad9a38a37d31cecfc1 100644 (file)
@@ -148,16 +148,14 @@ static void fsl_lpspi_intctrl(struct fsl_lpspi_data *fsl_lpspi,
        writel(enable, fsl_lpspi->base + IMX7ULP_IER);
 }
 
-static int fsl_lpspi_prepare_message(struct spi_master *master,
-                                    struct spi_message *msg)
+static int lpspi_prepare_xfer_hardware(struct spi_master *master)
 {
        struct fsl_lpspi_data *fsl_lpspi = spi_master_get_devdata(master);
 
        return clk_prepare_enable(fsl_lpspi->clk);
 }
 
-static int
-fsl_lpspi_unprepare_message(struct spi_master *master, struct spi_message *msg)
+static int lpspi_unprepare_xfer_hardware(struct spi_master *master)
 {
        struct fsl_lpspi_data *fsl_lpspi = spi_master_get_devdata(master);
 
@@ -438,8 +436,8 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
        fsl_lpspi->dev = &pdev->dev;
 
        master->transfer_one_message = fsl_lpspi_transfer_one_msg;
-       master->prepare_message = fsl_lpspi_prepare_message;
-       master->unprepare_message = fsl_lpspi_unprepare_message;
+       master->prepare_transfer_hardware = lpspi_prepare_xfer_hardware;
+       master->unprepare_transfer_hardware = lpspi_unprepare_xfer_hardware;
        master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH;
        master->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX;
        master->dev.of_node = pdev->dev.of_node;