]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drivers/thermal/rcar_gen3_thermal: Improve logging during probe
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Fri, 10 Jun 2022 20:04:59 +0000 (22:04 +0200)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 28 Jul 2022 15:29:44 +0000 (17:29 +0200)
When setting up a new board, a plain "Can't register thermal zone"
didn't help me much because the thermal zones in DT were all fine. I
just had a sensor entry too much in the parent TSC node. Reword the
failure/success messages to contain the sensor number to make it easier
to understand which sensor is affected. Example output now:

rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20220610200500.6727-1-wsa+renesas@sang-engineering.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/thermal/rcar_gen3_thermal.c

index 43eb25b167bc006ff0a1206772fc1dcfe48105cf..e2020c6308cc183e8eb961e256659dfbe20340e0 100644 (file)
@@ -507,7 +507,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
                zone = devm_thermal_zone_of_sensor_register(dev, i, tsc,
                                                            &rcar_gen3_tz_of_ops);
                if (IS_ERR(zone)) {
-                       dev_err(dev, "Can't register thermal zone\n");
+                       dev_err(dev, "Sensor %u: Can't register thermal zone\n", i);
                        ret = PTR_ERR(zone);
                        goto error_unregister;
                }
@@ -529,7 +529,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
                if (ret < 0)
                        goto error_unregister;
 
-               dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);
+               dev_info(dev, "Sensor %u: Loaded %d trip points\n", i, ret);
        }
 
        if (!priv->num_tscs) {