]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/tidss: Convert to drm logging
authorMaxime Ripard <mripard@kernel.org>
Tue, 2 Sep 2025 08:32:46 +0000 (10:32 +0200)
committerMaxime Ripard <mripard@kernel.org>
Tue, 30 Sep 2025 09:56:13 +0000 (11:56 +0200)
DRM drivers should prefer the drm logging functions to the dev logging
ones when possible. Let's convert the existing dev_* logs to their drm
counterparts.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250902-drm-state-readout-v1-18-14ad5315da3f@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20250902-drm-state-readout-v1-18-14ad5315da3f@kernel.org
drivers/gpu/drm/tidss/tidss_crtc.c
drivers/gpu/drm/tidss/tidss_dispc.c

index da89fd01c3376352840185cd4ac355dd41fd5bb1..f497138ad053ed4be207e12eeee6c304e1c949bd 100644 (file)
@@ -103,7 +103,7 @@ static int tidss_crtc_atomic_check(struct drm_crtc *crtc,
 
        ok = dispc_vp_mode_valid(dispc, hw_videoport, mode);
        if (ok != MODE_OK) {
-               dev_dbg(ddev->dev, "%s: bad mode: %ux%u pclk %u kHz\n",
+               drm_dbg(ddev, "%s: bad mode: %ux%u pclk %u kHz\n",
                        __func__, mode->hdisplay, mode->vdisplay, mode->clock);
                return -EINVAL;
        }
@@ -172,7 +172,7 @@ static void tidss_crtc_atomic_flush(struct drm_crtc *crtc,
        struct tidss_device *tidss = to_tidss(ddev);
        unsigned long flags;
 
-       dev_dbg(ddev->dev, "%s: %s is %sactive, %s modeset, event %p\n",
+       drm_dbg(ddev, "%s: %s is %sactive, %s modeset, event %p\n",
                __func__, crtc->name, crtc->state->active ? "" : "not ",
                drm_atomic_crtc_needs_modeset(crtc->state) ? "needs" : "doesn't need",
                crtc->state->event);
index 7c8c15a5c39b3fba6311596ea699e45713355b4a..52dcc566e6c06e9d7aa4833c494471b1963a029b 100644 (file)
@@ -1051,20 +1051,22 @@ struct dispc_bus_format *dispc_vp_find_bus_fmt(struct dispc_device *dispc,
 int dispc_vp_bus_check(struct dispc_device *dispc, u32 hw_videoport,
                       const struct drm_crtc_state *state)
 {
+       struct tidss_device *tidss = dispc->tidss;
+       struct drm_device *dev = &tidss->ddev;
        const struct tidss_crtc_state *tstate = to_tidss_crtc_state(state);
        const struct dispc_bus_format *fmt;
 
        fmt = dispc_vp_find_bus_fmt(dispc, hw_videoport, tstate->bus_format,
                                    tstate->bus_flags);
        if (!fmt) {
-               dev_dbg(dispc->dev, "%s: Unsupported bus format: %u\n",
+               drm_dbg(dev, "%s: Unsupported bus format: %u\n",
                        __func__, tstate->bus_format);
                return -EINVAL;
        }
 
        if (dispc->feat->vp_bus_type[hw_videoport] != DISPC_VP_OLDI_AM65X &&
            fmt->is_oldi_fmt) {
-               dev_dbg(dispc->dev, "%s: %s is not OLDI-port\n",
+               drm_dbg(dev, "%s: %s is not OLDI-port\n",
                        __func__, dispc->feat->vp_name[hw_videoport]);
                return -EINVAL;
        }