src: remove check for NULL before calling expr_free()

expr_free() already handles NULL pointer, remove redundant check.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c
index 1121f730ffa783d00c6150c45e0dff52cdeb5d10..bde783bdf4adcc27a02877bbf34d962480870ebc 100644 (file)
--- a/src/netlink_delinearize.c
+++ b/src/netlink_delinearize.c
@@ -83,8 +83,7 @@ static void netlink_set_register(struct netlink_parse_ctx *ctx,
                return;
        }
 
-       if (ctx->registers[reg] != NULL)
-               expr_free(ctx->registers[reg]);
+       expr_free(ctx->registers[reg]);
 
        ctx->registers[reg] = expr;
 }

diff --git a/src/rule.c b/src/rule.c
index 07b95a993275b5ca40aa7c8ec26e920c097c354f..35f6d8f28aee6285ab1322c4176d977c53feb28f 100644 (file)
--- a/src/rule.c
+++ b/src/rule.c
@@ -193,8 +193,8 @@ void set_free(struct set *set)
 
        if (--set->refcnt > 0)
                return;
-       if (set->init != NULL)
-               expr_free(set->init);
+
+       expr_free(set->init);
        if (set->comment)
                xfree(set->comment);
        handle_free(&set->handle);