]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/tests/core-kunit: remove unnecessary damon_ctx variable on damon_test_split_at()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:20:15 +0000 (11:20 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Nov 2025 01:28:35 +0000 (17:28 -0800)
damon_test_split_at() dynamically allocates a 'struct damon_ctx' object,
but it is not really being used in the code other than handling the
allocation failure and deallocating it at the end of the function.  Remove
the unnecessary allocation and deallocation of the object.

Link: https://lkml.kernel.org/r/20251101182021.74868-22-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/tests/core-kunit.h

index a91d798caa7044a7315da6dc5d93ea3ed3f65b58..726f593930e7fe2ef76ce76c75bba50f7b291d1a 100644 (file)
@@ -144,20 +144,14 @@ static void damon_test_aggregate(struct kunit *test)
 
 static void damon_test_split_at(struct kunit *test)
 {
-       struct damon_ctx *c = damon_new_ctx();
        struct damon_target *t;
        struct damon_region *r, *r_new;
 
-       if (!c)
-               kunit_skip(test, "ctx alloc fail");
        t = damon_new_target();
-       if (!t) {
-               damon_destroy_ctx(c);
+       if (!t)
                kunit_skip(test, "target alloc fail");
-       }
        r = damon_new_region(0, 100);
        if (!r) {
-               damon_destroy_ctx(c);
                damon_free_target(t);
                kunit_skip(test, "region alloc fail");
        }
@@ -178,7 +172,6 @@ static void damon_test_split_at(struct kunit *test)
        KUNIT_EXPECT_EQ(test, r->last_nr_accesses, r_new->last_nr_accesses);
 
        damon_free_target(t);
-       damon_destroy_ctx(c);
 }
 
 static void damon_test_merge_two(struct kunit *test)