]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t-reftable-merged: use reftable_ref_record_equal to compare ref records
authorChandra Pratap <chandrapratap3519@gmail.com>
Fri, 12 Jul 2024 05:39:02 +0000 (11:09 +0530)
committerJunio C Hamano <gitster@pobox.com>
Fri, 12 Jul 2024 16:55:41 +0000 (09:55 -0700)
In the test t_merged_single_record() defined in t-reftable-merged.c,
the 'input' and 'expected' ref records are checked for equality
by comparing their update indices. It is very much possible for
two different ref records to have the same update indices. Use
reftable_ref_record_equal() instead for a stronger check.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/unit-tests/t-reftable-merged.c

index 065b359200545145eec6830f783a4e5b603e250f..9f9275f87167bb256fe42274eebb61f7d7e08de0 100644 (file)
@@ -158,7 +158,7 @@ static void t_merged_single_record(void)
 
        err = reftable_iterator_next_ref(&it, &ref);
        check(!err);
-       check_int(ref.update_index, ==, 2);
+       check(reftable_ref_record_equal(&r2[0], &ref, GIT_SHA1_RAWSZ));
        reftable_ref_record_release(&ref);
        reftable_iterator_destroy(&it);
        readers_destroy(readers, 3);