]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libsmb: Simplify smb1cli_trans_recv()
authorVolker Lendecke <vl@samba.org>
Sun, 18 Aug 2024 09:29:46 +0000 (11:29 +0200)
committerVolker Lendecke <vl@samba.org>
Tue, 20 Aug 2024 09:34:40 +0000 (09:34 +0000)
tevent_req_received() called below takes care of this

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
libcli/smb/smb1cli_trans.c

index 99021ce2b47f91506afcd2d9700e45f2c0eb8d90..02b2b2efb08235d82647650a512cbdb716ed33d9 100644 (file)
@@ -822,22 +822,16 @@ NTSTATUS smb1cli_trans_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
        if (setup != NULL) {
                *setup = talloc_move(mem_ctx, &state->rsetup);
                *num_setup = state->num_rsetup;
-       } else {
-               TALLOC_FREE(state->rsetup);
        }
 
        if (param != NULL) {
                *param = talloc_move(mem_ctx, &state->rparam.data);
                *num_param = state->rparam.total;
-       } else {
-               TALLOC_FREE(state->rparam.data);
        }
 
        if (data != NULL) {
                *data = talloc_move(mem_ctx, &state->rdata.data);
                *num_data = state->rdata.total;
-       } else {
-               TALLOC_FREE(state->rdata.data);
        }
 
        status = state->status;