]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
dsync: Add assert to help static analyzers
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Wed, 16 Dec 2020 14:47:38 +0000 (16:47 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Wed, 13 Jan 2021 07:30:44 +0000 (07:30 +0000)
src/doveadm/dsync/dsync-mailbox-import.c

index cab057b569bfc553e63bbd004d7150b3f0cb2440..f5f073755a6ed4a32320bb6ccba87728bbdd978e 100644 (file)
@@ -877,8 +877,12 @@ static bool dsync_mailbox_try_save_cur(struct dsync_mailbox_importer *importer,
        newmail->change = save_change;
 
        array_push_back(&importer->newmails, &newmail);
-       newmail_link(importer, newmail,
-                    newmail->uid_in_local ? 0 : save_change->uid);
+       if (newmail->uid_in_local)
+               newmail_link(importer, newmail, 0);
+       else {
+               i_assert(save_change != NULL);
+               newmail_link(importer, newmail, save_change->uid);
+       }
        return remote_saved;
 }