]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdgpu: Enable async flip on overlay planes
authorAndré Almeida <andrealmeid@igalia.com>
Mon, 27 Jan 2025 19:59:40 +0000 (16:59 -0300)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thu, 13 Feb 2025 22:54:29 +0000 (00:54 +0200)
amdgpu can handle async flips on overlay planes, so allow it for atomic
async checks.

Signed-off-by: André Almeida <andrealmeid@igalia.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250127-tonyk-async_flip-v12-2-0f7f8a8610d3@igalia.com
[DB: fixed checkpatch warning by adding braces]
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c

index 774cc3f4f3fd9a964fe48c66eb596d2f6dfee602..82cf6ddcaffe46feb189d7f713677482af9bc444 100644 (file)
@@ -1258,21 +1258,24 @@ static int amdgpu_dm_plane_atomic_check(struct drm_plane *plane,
 }
 
 static int amdgpu_dm_plane_atomic_async_check(struct drm_plane *plane,
-                                             struct drm_atomic_state *state)
+                                             struct drm_atomic_state *state, bool flip)
 {
        struct drm_crtc_state *new_crtc_state;
        struct drm_plane_state *new_plane_state;
        struct dm_crtc_state *dm_new_crtc_state;
 
-       /* Only support async updates on cursor planes. */
-       if (plane->type != DRM_PLANE_TYPE_CURSOR)
+       if (flip) {
+               if (plane->type != DRM_PLANE_TYPE_OVERLAY)
+                       return -EINVAL;
+       } else if (plane->type != DRM_PLANE_TYPE_CURSOR) {
                return -EINVAL;
+       }
 
        new_plane_state = drm_atomic_get_new_plane_state(state, plane);
        new_crtc_state = drm_atomic_get_new_crtc_state(state, new_plane_state->crtc);
        dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
        /* Reject overlay cursors for now*/
-       if (dm_new_crtc_state->cursor_mode == DM_CURSOR_OVERLAY_MODE)
+       if (!flip && dm_new_crtc_state->cursor_mode == DM_CURSOR_OVERLAY_MODE)
                return -EINVAL;
 
        return 0;