]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
remoteproc: imx_dsp_rproc: Use devm_pm_runtime_enable() helper
authorPeng Fan <peng.fan@nxp.com>
Wed, 19 Nov 2025 04:21:48 +0000 (12:21 +0800)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Wed, 19 Nov 2025 16:07:03 +0000 (09:07 -0700)
Current code on the cleanup path just disables runtime PM for a device.

Using resource managed version devm_pm_runtime_enable() registers a cleanup
callback that sets autosuspend to false and then disables runtime PM for
a device. So, basically the same functionality as we don't use autosuspend
anyway.

As a result, the .remove callback is no longer needed, reducing boilerplate
code.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Tested-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20251119-imx-dsp-2025-11-19-v4-3-adafd342d07b@nxp.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/imx_dsp_rproc.c

index 418bd3ac70a4aa294b89c5d646a89e4da5ad2c35..f5d0aec52c56664d6074272e276edb0c4175c9ea 100644 (file)
@@ -1200,14 +1200,7 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev)
 
        rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA);
 
-       pm_runtime_enable(dev);
-
-       return 0;
-}
-
-static void imx_dsp_rproc_remove(struct platform_device *pdev)
-{
-       pm_runtime_disable(&pdev->dev);
+       return devm_pm_runtime_enable(dev);
 }
 
 /* pm runtime functions */
@@ -1358,7 +1351,6 @@ MODULE_DEVICE_TABLE(of, imx_dsp_rproc_of_match);
 
 static struct platform_driver imx_dsp_rproc_driver = {
        .probe = imx_dsp_rproc_probe,
-       .remove = imx_dsp_rproc_remove,
        .driver = {
                .name = "imx-dsp-rproc",
                .of_match_table = imx_dsp_rproc_of_match,