net: stmmac: simplify stmmac_check_pcs_mode()

Now that we only support one mode, simplify stmmac_check_pcs_mode().

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tested-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/E1v9P6d-0000000Aolw-1T7d@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 9a8dacf18c14c6031f292322648eb4b74fce8654..832062b2f4f31e01a88582e4671d03a9837fe6c5 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1086,22 +1086,23 @@ static const struct phylink_mac_ops stmmac_phylink_mac_ops = {
 static void stmmac_check_pcs_mode(struct stmmac_priv *priv)
 {
        int interface = priv->plat->phy_interface;
+       int speed = priv->plat->mac_port_sel_speed;
 
        if (priv->dma_cap.pcs && interface == PHY_INTERFACE_MODE_SGMII) {
                netdev_dbg(priv->dev, "PCS SGMII support enabled\n");
                priv->hw->pcs = STMMAC_PCS_SGMII;
-       }
-
-       /* PS and related bits will be programmed according to the speed */
-       if (priv->hw->pcs) {
-               int speed = priv->plat->mac_port_sel_speed;
 
-               if ((speed == SPEED_10) || (speed == SPEED_100) ||
-                   (speed == SPEED_1000)) {
+               switch (speed) {
+               case SPEED_10:
+               case SPEED_100:
+               case SPEED_1000:
                        priv->hw->ps = speed;
-               } else {
+                       break;
+
+               default:
                        dev_warn(priv->device, "invalid port speed\n");
                        priv->hw->ps = 0;
+                       break;
                }
        }
 }