]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
i2c: jz4780: drop superfluous init
authorWolfram Sang <wsa@the-dreams.de>
Sun, 5 Jun 2016 09:41:42 +0000 (11:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 Sep 2017 05:06:50 +0000 (07:06 +0200)
commit 27bfeb5a0619554d9734fb39e14f0e80fa7c342c upstream.

David reported that the length for memset was incorrect (element sizes
were not taken into account). Then I saw that we are clearing kzalloced
memory, so we can simply drop this code.

Reported-by: David Binderman <dcb314@hotmail.com>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/busses/i2c-jz4780.c

index f325663c27c532645a1901a385ac6d52543e5ba5..4b58e8aaf5c5165d791f47c2115b5a2bc4aff14e 100644 (file)
@@ -786,10 +786,6 @@ static int jz4780_i2c_probe(struct platform_device *pdev)
 
        jz4780_i2c_writew(i2c, JZ4780_I2C_INTM, 0x0);
 
-       i2c->cmd = 0;
-       memset(i2c->cmd_buf, 0, BUFSIZE);
-       memset(i2c->data_buf, 0, BUFSIZE);
-
        i2c->irq = platform_get_irq(pdev, 0);
        ret = devm_request_irq(&pdev->dev, i2c->irq, jz4780_i2c_irq, 0,
                               dev_name(&pdev->dev), i2c);