]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
fpga: socfpga: Rename 'timeout' variable as 'time_left'
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 29 Jul 2024 10:42:22 +0000 (12:42 +0200)
committerXu Yilun <yilun.xu@linux.intel.com>
Wed, 14 Aug 2024 15:57:07 +0000 (23:57 +0800)
There is a confusing pattern in the kernel to use a variable named
'timeout' to store the result of
wait_for_completion_interruptible_timeout() causing patterns like:

        timeout = wait_for_completion_interruptible_timeout(...)
        if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the
code self explaining.

Fix to the proper variable type 'long' while here.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20240729104319.2658-1-wsa+renesas@sang-engineering.com
Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
drivers/fpga/socfpga.c

index 723ea0ad3f09b6980f6d422edf192650229cf065..b08b4bb8f6507d5471b55f210ed54e3e84e0fe57 100644 (file)
@@ -301,16 +301,17 @@ static irqreturn_t socfpga_fpga_isr(int irq, void *dev_id)
 
 static int socfpga_fpga_wait_for_config_done(struct socfpga_fpga_priv *priv)
 {
-       int timeout, ret = 0;
+       int ret = 0;
+       long time_left;
 
        socfpga_fpga_disable_irqs(priv);
        init_completion(&priv->status_complete);
        socfpga_fpga_enable_irqs(priv, SOCFPGA_FPGMGR_MON_CONF_DONE);
 
-       timeout = wait_for_completion_interruptible_timeout(
+       time_left = wait_for_completion_interruptible_timeout(
                                                &priv->status_complete,
                                                msecs_to_jiffies(10));
-       if (timeout == 0)
+       if (time_left == 0)
                ret = -ETIMEDOUT;
 
        socfpga_fpga_disable_irqs(priv);