leds: cht-wcove: Use devm_led_classdev_register() to avoid memory leak

cht_wc_leds_probe() leaks memory when the second led_classdev_register()
call in the for-loop fails as it does not call the cleanup function
led_classdev_unregister() on the first device. Avoid this leak by
calling devm_led_classdev_register().

Fixes: 047da762b9a9 ("leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://lore.kernel.org/r/20241220085346.533675-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
index 8246f048edcb4b23255d51bdea13ee839b4df50b..9a609dd5acdc882bfd999730c1e3e64975614694 100644 (file)
--- a/drivers/leds/leds-cht-wcove.c
+++ b/drivers/leds/leds-cht-wcove.c
@@ -394,7 +394,7 @@ static int cht_wc_leds_probe(struct platform_device *pdev)
                led->cdev.pattern_clear = cht_wc_leds_pattern_clear;
                led->cdev.max_brightness = 255;
 
-               ret = led_classdev_register(&pdev->dev, &led->cdev);
+               ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
                if (ret < 0)
                        return ret;
        }
@@ -406,10 +406,6 @@ static int cht_wc_leds_probe(struct platform_device *pdev)
 static void cht_wc_leds_remove(struct platform_device *pdev)
 {
        struct cht_wc_leds *leds = platform_get_drvdata(pdev);
-       int i;
-
-       for (i = 0; i < CHT_WC_LED_COUNT; i++)
-               led_classdev_unregister(&leds->leds[i].cdev);
 
        /* Restore LED1 regs if hw-control was active else leave LED1 off */
        if (!(leds->led1_initial_regs.ctrl & CHT_WC_LED1_SWCTL))