]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_repair: don't leak buffer on xattr remote buf verifier error
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 23 May 2018 21:30:47 +0000 (16:30 -0500)
committerEric Sandeen <sandeen@redhat.com>
Wed, 23 May 2018 21:30:47 +0000 (16:30 -0500)
If we try to read an xattr remote buffer and hit a verifier error,
release the buffer instead of leaking it.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
repair/attr_repair.c

index 67bb41ec1a57d6efa29bd5bdf0e01e0539a26c4c..f2579fcb57e8ee1ae81e49a7c58c6d2da2967b62 100644 (file)
@@ -433,6 +433,7 @@ rmtval_get(xfs_mount_t *mp, xfs_ino_t ino, blkmap_t *blkmap,
                if (bp->b_error == -EFSBADCRC || bp->b_error == -EFSCORRUPTED) {
                        do_warn(
        _("Corrupt remote block for attributes of inode %" PRIu64 "\n"), ino);
+                       libxfs_putbuf(bp);
                        clearit = 1;
                        break;
                }