]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
can: rcar_canfd: Invert reset assert order
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 24 Nov 2025 10:28:26 +0000 (10:28 +0000)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 26 Nov 2025 10:21:55 +0000 (11:21 +0100)
The two resets are asserted during cleanup in the same order as they
were deasserted during probe.  Invert the order to restore symmetry.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Vincent Mailhol <mailhol@kernel.org>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://patch.msgid.link/20251124102837.106973-2-biju.das.jz@bp.renesas.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/rcar/rcar_canfd.c

index 49ab65274b51dc929157ab2184139ce33b4ea271..cbcc971cda9ae51cfcb5a4f6ae282ea91f2db654 100644 (file)
@@ -2192,8 +2192,8 @@ fail_mode:
 fail_clk:
        clk_disable_unprepare(gpriv->clkp);
 fail_reset:
-       reset_control_assert(gpriv->rstc1);
        reset_control_assert(gpriv->rstc2);
+       reset_control_assert(gpriv->rstc1);
 fail_dev:
        return err;
 }
@@ -2214,8 +2214,8 @@ static void rcar_canfd_remove(struct platform_device *pdev)
        /* Enter global sleep mode */
        rcar_canfd_set_bit(gpriv->base, RCANFD_GCTR, RCANFD_GCTR_GSLPR);
        clk_disable_unprepare(gpriv->clkp);
-       reset_control_assert(gpriv->rstc1);
        reset_control_assert(gpriv->rstc2);
+       reset_control_assert(gpriv->rstc1);
 }
 
 static int __maybe_unused rcar_canfd_suspend(struct device *dev)