]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts
authorBreno Leitao <leitao@debian.org>
Tue, 1 Apr 2025 13:47:49 +0000 (06:47 -0700)
committerMark Brown <broonie@kernel.org>
Tue, 15 Apr 2025 18:48:24 +0000 (19:48 +0100)
Some machines with tegra_qspi_combined_seq_xfer hardware issues generate
excessive kernel warnings, severely polluting the logs:

    dmesg | grep -i "WARNING:.*tegra_qspi_transfer_one_message" | wc -l
    94451

This patch replaces WARN_ON with WARN_ON_ONCE for timeout conditions to
reduce log spam. The subsequent error message still prints on each
occurrence, providing sufficient information about the failure, while
the stack trace is only needed once for debugging purposes.

Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20250401-tegra-v2-1-126c293ec047@debian.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra210-quad.c

index 08e49a8768943c1cf12fe2f2893e5eae1bf70d0f..2d320fbb8875f0c6936242bb0b911442b9ce8c3f 100644 (file)
@@ -1117,7 +1117,7 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi,
                                        (&tqspi->xfer_completion,
                                        QSPI_DMA_TIMEOUT);
 
-                       if (WARN_ON(ret == 0)) {
+                       if (WARN_ON_ONCE(ret == 0)) {
                                dev_err(tqspi->dev, "QSPI Transfer failed with timeout: %d\n",
                                        ret);
                                if (tqspi->is_curr_dma_xfer &&