P2P: Extend group formation timeout on GO to first data connection

Previously, GO considered the group to be fully formed at the completed
of WPS provisioning step. This would leave the group running until idle
timeout (which may not be enabled) or explicit removal if the client
fails to connect for any reason. Since the client is expected to connect
immediately after the WPS provisioning step, extend group formation
timeout to cover that period until the first successfully completed data
connection. This allows the GO to remove the group automatically if the
client devices does not connect within P2P_MAX_INITIAL_CONN_WAIT_GO (10)
seconds.

Signed-hostap: Jouni Malinen <jouni@qca.qualcomm.com>

diff --git a/wpa_supplicant/p2p_supplicant.c b/wpa_supplicant/p2p_supplicant.c
index 882c1d5812a8470ba321e0bc498beda5a6e8e869..36e32f10030e4e0666aa699b3524ebaac857b569 100644 (file)
--- a/wpa_supplicant/p2p_supplicant.c
+++ b/wpa_supplicant/p2p_supplicant.c
@@ -710,8 +710,10 @@ static void wpas_group_formation_completed(struct wpa_supplicant *wpa_s,
         */
        if (wpa_s->global->p2p_group_formation)
                wpa_s = wpa_s->global->p2p_group_formation;
-       wpa_s->global->p2p_group_formation = NULL;
-       wpa_s->p2p_in_provisioning = 0;
+       if (wpa_s->p2p_go_group_formation_completed) {
+               wpa_s->global->p2p_group_formation = NULL;
+               wpa_s->p2p_in_provisioning = 0;
+       }
 
        if (!success) {
                wpa_msg_global(wpa_s->parent, MSG_INFO,
@@ -4739,6 +4741,7 @@ void wpas_p2p_wps_success(struct wpa_supplicant *wpa_s, const u8 *peer_addr,
 
        eloop_cancel_timeout(wpas_p2p_group_formation_timeout, wpa_s->parent,
                             NULL);
+       wpa_s->p2p_go_group_formation_completed = 1;
        if (ssid && ssid->mode == WPAS_MODE_INFRA) {
                /*
                 * Use a separate timeout for initial data connection to
@@ -4746,9 +4749,28 @@ void wpas_p2p_wps_success(struct wpa_supplicant *wpa_s, const u8 *peer_addr,
                 * something goes wrong in this step before the P2P group idle
                 * timeout mechanism is taken into use.
                 */
+               wpa_dbg(wpa_s, MSG_DEBUG,
+                       "P2P: Re-start group formation timeout (%d seconds) as client for initial connection",
+                       P2P_MAX_INITIAL_CONN_WAIT);
                eloop_register_timeout(P2P_MAX_INITIAL_CONN_WAIT, 0,
                                       wpas_p2p_group_formation_timeout,
                                       wpa_s->parent, NULL);
+       } else if (ssid) {
+               /*
+                * Use a separate timeout for initial data connection to
+                * complete to allow the group to be removed automatically if
+                * the client does not complete data connection successfully.
+                */
+               wpa_dbg(wpa_s, MSG_DEBUG,
+                       "P2P: Re-start group formation timeout (%d seconds) as GO for initial connection",
+                       P2P_MAX_INITIAL_CONN_WAIT_GO);
+               eloop_register_timeout(P2P_MAX_INITIAL_CONN_WAIT_GO, 0,
+                                      wpas_p2p_group_formation_timeout,
+                                      wpa_s->parent, NULL);
+               /*
+                * Complete group formation on first successful data connection
+                */
+               wpa_s->p2p_go_group_formation_completed = 0;
        }
        if (wpa_s->global->p2p)
                p2p_wps_success_cb(wpa_s->global->p2p, peer_addr);
@@ -5951,9 +5973,18 @@ void wpas_p2p_notify_ap_sta_authorized(struct wpa_supplicant *wpa_s,
                 * This can happen if WPS provisioning step is not terminated
                 * cleanly (e.g., P2P Client does not send WSC_Done). Since the
                 * peer was able to connect, there is no need to time out group
-                * formation after this, though.
+                * formation after this, though. In addition, this is used with
+                * the initial connection wait on the GO as a separate formation
+                * timeout and as such, expected to be hit after the initial WPS
+                * provisioning step.
                 */
-               wpa_printf(MSG_DEBUG, "P2P: Workaround - cancelled P2P group formation timeout on data connection");
+               wpa_printf(MSG_DEBUG, "P2P: Canceled P2P group formation timeout on data connection");
+       }
+       if (!wpa_s->p2p_go_group_formation_completed) {
+               wpa_dbg(wpa_s, MSG_DEBUG, "P2P: Marking group formation completed on GO on first data connection");
+               wpa_s->p2p_go_group_formation_completed = 1;
+               wpa_s->global->p2p_group_formation = NULL;
+               wpa_s->p2p_in_provisioning = 0;
        }
        wpa_s->global->p2p_go_wait_client.sec = 0;
        if (addr == NULL)

diff --git a/wpa_supplicant/wpa_supplicant_i.h b/wpa_supplicant/wpa_supplicant_i.h
index d69cd61c91ea63699822dc2c663948ccabd67938..065a98195686c7d784965ea5c4a57835824ff901 100644 (file)
--- a/wpa_supplicant/wpa_supplicant_i.h
+++ b/wpa_supplicant/wpa_supplicant_i.h
@@ -647,6 +647,7 @@ struct wpa_supplicant {
        unsigned int p2p_pd_before_go_neg:1;
        unsigned int p2p_go_ht40:1;
        unsigned int user_initiated_pd:1;
+       unsigned int p2p_go_group_formation_completed:1;
        int p2p_persistent_go_freq;
        int p2p_persistent_id;
        int p2p_go_intent;