t9400: don't use test_must_fail with cvs

We are using `test_must_fail cvs` to test that the cvs command fails as
expected. However, test_must_fail() is used to ensure that commands fail
in an expected way, not due to something like a segv. Since we are not
in the business of verifying the sanity of the external world, replace
`test_must_fail cvs` with `! cvs` and assume that the cvs command does
not die unexpectedly.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh
index a5e5dca75341561894d681410aaeec6e365144fc..4a46f31c41933e7d2e5c72e47aebf5abd9d7bb3e 100755 (executable)
--- a/t/t9400-git-cvsserver-server.sh
+++ b/t/t9400-git-cvsserver-server.sh
@@ -603,7 +603,7 @@ test_expect_success 'cvs server does not run with vanilla git-shell' '
                cd cvswork &&
                CVS_SERVER=$WORKDIR/remote-cvs &&
                export CVS_SERVER &&
-               test_must_fail cvs log merge
+               ! cvs log merge
        )
 '