]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
function_graph: Use for_each_set_bit() in __ftrace_return_to_handler()
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 3 Jun 2024 19:07:26 +0000 (15:07 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 4 Jun 2024 14:38:03 +0000 (10:38 -0400)
Instead of iterating through the entire fgraph_array[] and seeing if one
of the bitmap bits are set to know to call the array's retfunc() function,
use for_each_set_bit() on the bitmap itself. This will only iterate for
the number of set bits.

Link: https://lore.kernel.org/linux-trace-kernel/20240603190824.447448026@goodmis.org
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Florent Revest <revest@chromium.org>
Cc: Martin KaFai Lau <martin.lau@linux.dev>
Cc: bpf <bpf@vger.kernel.org>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alan Maguire <alan.maguire@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Guo Ren <guoren@kernel.org>
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/fgraph.c

index f207b7ae5f461fc5bde7f8072eb596a41d829152..0827b67f746da2d0f486d5c545c9024c10dc062f 100644 (file)
@@ -783,11 +783,10 @@ static unsigned long __ftrace_return_to_handler(struct fgraph_ret_regs *ret_regs
 #endif
 
        bitmap = get_bitmap_bits(current, offset);
-       for (i = 0; i < FGRAPH_ARRAY_SIZE; i++) {
+
+       for_each_set_bit(i, &bitmap, sizeof(bitmap) * BITS_PER_BYTE) {
                struct fgraph_ops *gops = fgraph_array[i];
 
-               if (!(bitmap & BIT(i)))
-                       continue;
                if (gops == &fgraph_stub)
                        continue;