net: ravb: Fix RX frame size limit

The value written to the RFLR register includes the length of the CRC
data at the end of each Ethernet frame. So we need to increase the value
written to this register to ensure that we can receive full size frames.

While we're here we can also copy the improved comment from the Linux
kernel.

Fixes: 8ae51b6f324e ("net: ravb: Add Renesas Ethernet RAVB driver")
Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> # Fix comment
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c
index 6129929568a3890a5bd79fa205a63dd74cfe3884..c39bef17b794b163c48027b056033b3b9837d9cf 100644 (file)
--- a/drivers/net/ravb.c
+++ b/drivers/net/ravb.c
@@ -354,8 +354,15 @@ static int ravb_mac_init(struct ravb_priv *eth)
        /* Disable MAC Interrupt */
        writel(0, eth->iobase + RAVB_REG_ECSIPR);
 
-       /* Recv frame limit set register */
-       writel(RFLR_RFL_MIN, eth->iobase + RAVB_REG_RFLR);
+       /*
+        * Set receive frame length
+        *
+        * The length set here describes the frame from the destination address
+        * up to and including the CRC data. However only the frame data,
+        * excluding the CRC, are transferred to memory. To allow for the
+        * largest frames add the CRC length to the maximum Rx descriptor size.
+        */
+       writel(RFLR_RFL_MIN + ETH_FCS_LEN, eth->iobase + RAVB_REG_RFLR);
 
        return 0;
 }