]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name()
authorGabor Juhos <j4g8y7@gmail.com>
Wed, 14 May 2025 19:18:38 +0000 (21:18 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 14 May 2025 22:18:14 +0000 (00:18 +0200)
The regmap_update_bits() function can fail, so propagate its error
up to the stack instead of silently ignoring that.

Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-7-07e9ac1ab737@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

index 18c6c5026b26c294ee65e3deea02d2e852e10622..f35bf0cd98c97419ba0ab0291a23d4774a595d39 100644 (file)
@@ -358,9 +358,7 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev *pctldev,
 
        val = grp->val[func];
 
-       regmap_update_bits(info->regmap, reg, mask, val);
-
-       return 0;
+       return regmap_update_bits(info->regmap, reg, mask, val);
 }
 
 static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,