]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
i3c: mipi-i3c-hci: Remove nonexistent ring interrupt
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Wed, 27 Aug 2025 10:30:06 +0000 (13:30 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 16 Sep 2025 15:06:42 +0000 (17:06 +0200)
Ring interrupt bit 7, INTR_WARN_INS_STOP_MODE was probably drafted at
some point but is marked as reserved in the MIPI I3C HCI specification
versions 1.1 and 1.2 that came out after the initial code and also in
the earlier specification versions so remove it.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250827103009.243771-3-jarkko.nikula@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/mipi-i3c-hci/dma.c

index f5f5ab4db172e873e85a6a77558439a00e586a86..8bc9de1895435cad510224c3f9d64a5684938de3 100644 (file)
@@ -77,7 +77,6 @@
 #define INTR_TRANSFER_COMPLETION       BIT(11)
 #define INTR_RING_OP                   BIT(10)
 #define INTR_TRANSFER_ERR              BIT(9)
-#define INTR_WARN_INS_STOP_MODE                BIT(7)
 #define INTR_IBI_RING_FULL             BIT(6)
 #define INTR_TRANSFER_ABORT            BIT(5)
 
@@ -278,7 +277,6 @@ static int hci_dma_init(struct i3c_hci *hci)
                                                 INTR_TRANSFER_COMPLETION |
                                                 INTR_RING_OP |
                                                 INTR_TRANSFER_ERR |
-                                                INTR_WARN_INS_STOP_MODE |
                                                 INTR_IBI_RING_FULL |
                                                 INTR_TRANSFER_ABORT);
 
@@ -795,9 +793,6 @@ static bool hci_dma_irq_handler(struct i3c_hci *hci)
                                                           RING_CTRL_RUN_STOP);
                        }
                }
-               if (status & INTR_WARN_INS_STOP_MODE)
-                       dev_warn_ratelimited(&hci->master.dev,
-                               "ring %d: Inserted Stop on Mode Change\n", i);
                if (status & INTR_IBI_RING_FULL)
                        dev_err_ratelimited(&hci->master.dev,
                                "ring %d: IBI Ring Full Condition\n", i);