]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: iqs269a - use device_for_each_child_node_scoped()
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Fri, 12 Apr 2024 20:57:30 +0000 (22:57 +0200)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 15 Jul 2024 23:45:52 +0000 (16:45 -0700)
Switch to the _scoped() version introduced in commit 365130fd47af
("device property: Introduce device_for_each_child_node_scoped()")
to remove the need for manual calling of fwnode_handle_put() in the
paths where the code exits the loop early.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240412-input_device_for_each_child_node_scoped-v1-1-dbad1bc7ea84@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/iqs269a.c

index cd14ff9f57cf239819d76cf3bae0da8c13524655..843f8a3f3410d42cf897c7ac81009682bf1d7172 100644 (file)
@@ -811,7 +811,6 @@ static int iqs269_parse_prop(struct iqs269_private *iqs269)
 {
        struct iqs269_sys_reg *sys_reg = &iqs269->sys_reg;
        struct i2c_client *client = iqs269->client;
-       struct fwnode_handle *ch_node;
        u16 general, misc_a, misc_b;
        unsigned int val;
        int error;
@@ -1049,12 +1048,10 @@ static int iqs269_parse_prop(struct iqs269_private *iqs269)
 
        sys_reg->event_mask = ~((u8)IQS269_EVENT_MASK_SYS);
 
-       device_for_each_child_node(&client->dev, ch_node) {
+       device_for_each_child_node_scoped(&client->dev, ch_node) {
                error = iqs269_parse_chan(iqs269, ch_node);
-               if (error) {
-                       fwnode_handle_put(ch_node);
+               if (error)
                        return error;
-               }
        }
 
        /*