]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
gcc-shared-source: do not use ${S}/.. in deploy_source_date_epoch
authorPeter Marko <peter.marko@siemens.com>
Thu, 23 Mar 2023 12:25:16 +0000 (13:25 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 25 Mar 2023 09:39:26 +0000 (09:39 +0000)
This function is referencing '${S}/..'.
It uses ${S} only as good known directory path to start
traversing from, and it does not need it to exist or be populated.
If ${S} does not exist yet, the function will fail because
it cannot evaluate path .. from non-existing directory.

Reproducer (verified in master and kirkstone):
  bitbake gcc -c deploy_source_date_epoch
  bitbake gcc -c cleansstate
  rm -rf build/tmp
  bitbake gcc -c deploy_source_date_epoch

Signed-off-by: Peter Marko <peter.marko@siemens.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
meta/recipes-devtools/gcc/gcc-shared-source.inc

index cd2e34109951b72a092ffc917cac1878527f3eb0..03f520b0933dc2bc20b3c3b4a17e1f1d2e85a9fb 100644 (file)
@@ -16,6 +16,6 @@ do_deploy_source_date_epoch () {
        sde_file=${SDE_FILE}
        sde_file=${sde_file#${WORKDIR}/}
        mkdir -p ${SDE_DEPLOYDIR} $(dirname ${SDE_FILE})
-       cp -p ${S}/../$sde_file ${SDE_DEPLOYDIR}
-       cp -p ${S}/../$sde_file ${SDE_FILE}
+       cp -p $(dirname ${S})/$sde_file ${SDE_DEPLOYDIR}
+       cp -p $(dirname ${S})/$sde_file ${SDE_FILE}
 }