]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ath10k: snoc: use correct bus-specific pointer in RX retry
authorBrian Norris <briannorris@chromium.org>
Mon, 11 Jun 2018 21:09:43 +0000 (14:09 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 14 Jun 2018 15:14:53 +0000 (18:14 +0300)
We're 'ath10k_snoc', not 'ath10k_pci'. This probably means we're
accessing junk data in ath10k_snoc_rx_replenish_retry(), unless
'ath10k_snoc' and 'ath10k_pci' happen to have very similar struct
layouts.

Noticed by inspection.

Fixes: d915105231ca ("ath10k: add hif rx methods for wcn3990")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/snoc.c

index 31d1e3af85a2c90739013a680167ee9b2c972526..42aa1d57a48599599c66bda4574f74bf898c2d14 100644 (file)
@@ -449,7 +449,7 @@ static void ath10k_snoc_htt_rx_cb(struct ath10k_ce_pipe *ce_state)
 
 static void ath10k_snoc_rx_replenish_retry(struct timer_list *t)
 {
-       struct ath10k_pci *ar_snoc = from_timer(ar_snoc, t, rx_post_retry);
+       struct ath10k_snoc *ar_snoc = from_timer(ar_snoc, t, rx_post_retry);
        struct ath10k *ar = ar_snoc->ar;
 
        ath10k_snoc_rx_post(ar);