]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
submission-login: proxy - Change impossible code path to assert
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Wed, 29 Apr 2020 13:14:06 +0000 (16:14 +0300)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Mon, 25 May 2020 08:38:55 +0000 (08:38 +0000)
src/submission-login/submission-proxy.c

index 4163b319ced02c7f6a8d28b892d736df62fff2b2..622b3470f7636ea0cdcfaa0246af453b8d1824da 100644 (file)
@@ -431,13 +431,10 @@ int submission_proxy_parse_line(struct client *client, const char *line)
           So for now we'll just forward the error message. This
           shouldn't be a real problem since of course everyone will
           be using only Dovecot as their backend :) */
-       if ((status / 100) == 2) {
-               submission_proxy_error(client, AUTH_FAILED_MSG);
-       } else {
-               i_assert(subm_client->proxy_reply != NULL);
-               smtp_server_reply_submit(subm_client->proxy_reply);
-               subm_client->pending_auth = NULL;
-       }
+       i_assert((status / 100) != 2);
+       i_assert(subm_client->proxy_reply != NULL);
+       smtp_server_reply_submit(subm_client->proxy_reply);
+       subm_client->pending_auth = NULL;
 
        if (client->set->auth_verbose) {
                client_proxy_log_failure(client, text);