]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: atr: find_mapping() -> get_mapping()
authorCosmin Tanislav <demonsingur@gmail.com>
Wed, 7 May 2025 12:19:08 +0000 (15:19 +0300)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 22 May 2025 09:07:04 +0000 (11:07 +0200)
A find operation implies that a null result is not an error.

Use get naming to clarify things and to prepare for splitting up the
logic inside this function.

Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
drivers/i2c/i2c-atr.c

index 9ec1678761064f7fab35588ec64ca7c14f42c8b7..43696f838073a9301b95dad4b5e64198ca24c38d 100644 (file)
@@ -241,7 +241,7 @@ static void i2c_atr_release_alias(struct i2c_atr_alias_pool *alias_pool, u16 ali
 
 /* Must be called with alias_pairs_lock held */
 static struct i2c_atr_alias_pair *
-i2c_atr_find_mapping_by_addr(struct i2c_atr_chan *chan, u16 addr)
+i2c_atr_get_mapping_by_addr(struct i2c_atr_chan *chan, u16 addr)
 {
        struct i2c_atr *atr = chan->atr;
        struct i2c_atr_alias_pair *c2a;
@@ -339,7 +339,7 @@ static int i2c_atr_map_msgs(struct i2c_atr_chan *chan, struct i2c_msg *msgs,
        for (i = 0; i < num; i++) {
                chan->orig_addrs[i] = msgs[i].addr;
 
-               c2a = i2c_atr_find_mapping_by_addr(chan, msgs[i].addr);
+               c2a = i2c_atr_get_mapping_by_addr(chan, msgs[i].addr);
 
                if (!c2a) {
                        dev_err(atr->dev, "client 0x%02x not mapped!\n",
@@ -432,7 +432,7 @@ static int i2c_atr_smbus_xfer(struct i2c_adapter *adap, u16 addr,
 
        mutex_lock(&chan->alias_pairs_lock);
 
-       c2a = i2c_atr_find_mapping_by_addr(chan, addr);
+       c2a = i2c_atr_get_mapping_by_addr(chan, addr);
 
        if (!c2a) {
                dev_err(atr->dev, "client 0x%02x not mapped!\n", addr);
@@ -540,7 +540,7 @@ static void i2c_atr_detach_addr(struct i2c_adapter *adapter,
 
        mutex_lock(&chan->alias_pairs_lock);
 
-       c2a = i2c_atr_find_mapping_by_addr(chan, addr);
+       c2a = i2c_atr_get_mapping_by_addr(chan, addr);
        if (!c2a) {
                 /* This should never happen */
                dev_warn(atr->dev, "Unable to find address mapping\n");