]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/vc4: Correct generation check in vc4_hvs_lut_load
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Tue, 8 Oct 2024 16:44:36 +0000 (17:44 +0100)
committerDave Stevenson <dave.stevenson@raspberrypi.com>
Wed, 9 Oct 2024 11:11:03 +0000 (12:11 +0100)
Commit 24c5ed3ddf27 ("drm/vc4: Introduce generation number enum")
incorrectly swapped a check of hvs->vc4->is_vc5 to
hvs->vc4->gen == VC4_GEN_4 in vc4_hvs_lut_load, hence breaking
loading the gamma look up table on Pi0-3.

Correct that conditional.

Fixes: 24c5ed3ddf27 ("drm/vc4: Introduce generation number enum")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/dri-devel/37051126-3921-4afe-a936-5f828bff5752@samsung.com/
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: MaĆ­ra Canal <mcanal@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241008-drm-vc4-fixes-v1-3-9d0396ca9f42@raspberrypi.com
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/gpu/drm/vc4/vc4_hvs.c

index c5ebc317188a09eb75f57f06ff393720fdcf2e3a..1edf6e3fa7e6412f4f7af42cd697be08ab829e0d 100644 (file)
@@ -224,7 +224,7 @@ static void vc4_hvs_lut_load(struct vc4_hvs *hvs,
        if (!drm_dev_enter(drm, &idx))
                return;
 
-       if (hvs->vc4->gen == VC4_GEN_4)
+       if (hvs->vc4->gen != VC4_GEN_4)
                goto exit;
 
        /* The LUT memory is laid out with each HVS channel in order,