RDMA/rxe: Removed unused name from rxe_task struct

[ Upstream commit de669ae8af49ceed0eed44f5b3d51dc62affc5e4 ]

The name field in struct rxe_task is never used. This patch removes it.

Link: https://lore.kernel.org/r/20221021200118.2163-4-rpearsonhpe@gmail.com
Signed-off-by: Ian Ziemba <ian.ziemba@hpe.com>
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Stable-dep-of: 2a62b6210ce8 ("RDMA/rxe: Fix the use-before-initialization error of resp_pkts")
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
index 5b59907594f75072f96078e7f0d3713c151d8079..c36000e08f65dafefc226fbe725109107500952f 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_qp.c
+++ b/drivers/infiniband/sw/rxe/rxe_qp.c
@@ -278,10 +278,8 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp,
 
        skb_queue_head_init(&qp->req_pkts);
 
-       rxe_init_task(&qp->req.task, qp,
-                     rxe_requester, "req");
-       rxe_init_task(&qp->comp.task, qp,
-                     rxe_completer, "comp");
+       rxe_init_task(&qp->req.task, qp, rxe_requester);
+       rxe_init_task(&qp->comp.task, qp, rxe_completer);
 
        qp->qp_timeout_jiffies = 0; /* Can't be set for UD/UC in modify_qp */
        if (init->qp_type == IB_QPT_RC) {
@@ -327,8 +325,7 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp,
 
        skb_queue_head_init(&qp->resp_pkts);
 
-       rxe_init_task(&qp->resp.task, qp,
-                     rxe_responder, "resp");
+       rxe_init_task(&qp->resp.task, qp, rxe_responder);
 
        qp->resp.opcode         = OPCODE_NONE;
        qp->resp.msn            = 0;

diff --git a/drivers/infiniband/sw/rxe/rxe_task.c b/drivers/infiniband/sw/rxe/rxe_task.c
index ea7d5a69eb2a3e84e67a104d5658df3c1f07f09f..39b3adda16550e850ba890e81312ae4682c2be28 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_task.c
+++ b/drivers/infiniband/sw/rxe/rxe_task.c
@@ -114,12 +114,10 @@ void rxe_do_task(unsigned long data)
        task->ret = ret;
 }
 
-int rxe_init_task(struct rxe_task *task,
-                 void *arg, int (*func)(void *), char *name)
+int rxe_init_task(struct rxe_task *task, void *arg, int (*func)(void *))
 {
        task->arg       = arg;
        task->func      = func;
-       snprintf(task->name, sizeof(task->name), "%s", name);
        task->destroyed = false;
 
        tasklet_init(&task->tasklet, rxe_do_task, (unsigned long)task);

diff --git a/drivers/infiniband/sw/rxe/rxe_task.h b/drivers/infiniband/sw/rxe/rxe_task.h
index e87ee072e317933ba95d6923494cb6df67cab935..ecd81b1d1a8cbf0b56661cfffdc08d8a83d2ae70 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_task.h
+++ b/drivers/infiniband/sw/rxe/rxe_task.h
@@ -52,7 +52,6 @@ struct rxe_task {
        void                    *arg;
        int                     (*func)(void *arg);
        int                     ret;
-       char                    name[16];
        bool                    destroyed;
 };
 
@@ -61,8 +60,7 @@ struct rxe_task {
  *     arg  => parameter to pass to fcn
  *     fcn  => function to call until it returns != 0
  */
-int rxe_init_task(struct rxe_task *task,
-                 void *arg, int (*func)(void *), char *name);
+int rxe_init_task(struct rxe_task *task, void *arg, int (*func)(void *));
 
 /* cleanup task */
 void rxe_cleanup_task(struct rxe_task *task);