Cleanup: use SBuf::npos instead of npos in SBuf::append()

Small experiment. It is possible on some systems that std::npos / ::npos
is defined with a different integer size and value.
This may be what is confusing Coverity scan and producing buffer overrun
alerts in the append() c-string with default parameter case.

diff --git a/src/SBuf.cc b/src/SBuf.cc
index fb9e989505f6b101c0bfa7bd6efa3b353296b0a0..11848943810936cc4723c6ec39974c1630552254 100644 (file)
--- a/src/SBuf.cc
+++ b/src/SBuf.cc
@@ -210,7 +210,7 @@ SBuf::append(const char * S, size_type Ssize)
 {
     if (S == NULL)
         return *this;
-    if (Ssize == npos)
+    if (Ssize == SBuf::npos)
         Ssize = strlen(S);
     debugs(24, 7, "from c-string to id " << id);
     // coverity[access_dbuff_in_call]