PR 51646 Use POSIX mode flags in open() argument.

2011-12-22  Janne Blomqvist  <jb@gcc.gnu.org>
	Tobias Burnus  <burnus@net-b.de>

	PR libfortran/51646
	* acinclude.m4 (LIBGFOR_CHECK_UNLINK_OPEN_FILE): Use POSIX mode
	flags, omit mode argument when flags argument does not have
	O_CREAT.
	* io/unix.c (tempfile): Use POSIX mode flags.
	* configure: Regenerate.

Co-Authored-By: Tobias Burnus <burnus@net-b.de>
From-SVN: r182638

diff --git a/libgfortran/ChangeLog b/libgfortran/ChangeLog
index 750428fec7a4431ba60aa9833186df2a4ab4f6c4..f516bad104903456699a4035b1f08807a40a8eb5 100644 (file)
--- a/libgfortran/ChangeLog
+++ b/libgfortran/ChangeLog
@@ -1,3 +1,13 @@
+2011-12-22  Janne Blomqvist  <jb@gcc.gnu.org>
+       Tobias Burnus  <burnus@net-b.de>
+
+       PR libfortran/51646
+       * acinclude.m4 (LIBGFOR_CHECK_UNLINK_OPEN_FILE): Use POSIX mode
+       flags, omit mode argument when flags argument does not have
+       O_CREAT.
+       * io/unix.c (tempfile): Use POSIX mode flags.
+       * configure: Regenerate.
+
 2011-11-21  Andreas Tobler  <andreast@fgznet.ch>
 
        * configure: Regenerate.

diff --git a/libgfortran/acinclude.m4 b/libgfortran/acinclude.m4
index b6cb40430afe0b978a2163a1d4aeb4921ef2ee98..645b248deb4293bc4150468f9ce7791df5475668 100644 (file)
--- a/libgfortran/acinclude.m4
+++ b/libgfortran/acinclude.m4
@@ -119,7 +119,7 @@ int main ()
 {
   int fd;
 
-  fd = open ("testfile", O_RDWR | O_CREAT, S_IWRITE | S_IREAD);
+  fd = open ("testfile", O_RDWR | O_CREAT, S_IWUSR | S_IRUSR);
   if (fd <= 0)
     return 0;
   if (unlink ("testfile") == -1)
@@ -127,7 +127,7 @@ int main ()
   write (fd, "This is a test\n", 15);
   close (fd);
 
-  if (open ("testfile", O_RDONLY, S_IWRITE | S_IREAD) == -1 && errno == ENOENT)
+  if (open ("testfile", O_RDONLY) == -1 && errno == ENOENT)
     return 0;
   else
     return 1;

diff --git a/libgfortran/configure b/libgfortran/configure
index 6ae1f09f48c10ce40696d82c4b34afed5dcb8897..3ce3d08ae89dc0693873495267e755d8c30e8f16 100755 (executable)
--- a/libgfortran/configure
+++ b/libgfortran/configure
@@ -25598,7 +25598,7 @@ int main ()
 {
   int fd;
 
-  fd = open ("testfile", O_RDWR | O_CREAT, S_IWRITE | S_IREAD);
+  fd = open ("testfile", O_RDWR | O_CREAT, S_IWUSR | S_IRUSR);
   if (fd <= 0)
     return 0;
   if (unlink ("testfile") == -1)
@@ -25606,7 +25606,7 @@ int main ()
   write (fd, "This is a test\n", 15);
   close (fd);
 
-  if (open ("testfile", O_RDONLY, S_IWRITE | S_IREAD) == -1 && errno == ENOENT)
+  if (open ("testfile", O_RDONLY) == -1 && errno == ENOENT)
     return 0;
   else
     return 1;

diff --git a/libgfortran/io/unix.c b/libgfortran/io/unix.c
index f320733e85986783d8e9ea6cbf4aea88452b689f..6eef3f99a0a9c3f9898e9376d74057a30c8819a4 100644 (file)
--- a/libgfortran/io/unix.c
+++ b/libgfortran/io/unix.c
@@ -1112,9 +1112,9 @@ tempfile (st_parameter_open *opp)
 
 #if defined(HAVE_CRLF) && defined(O_BINARY)
       fd = open (template, O_RDWR | O_CREAT | O_EXCL | O_BINARY,
-                S_IREAD | S_IWRITE);
+                S_IRUSR | S_IWUSR);
 #else
-      fd = open (template, O_RDWR | O_CREAT | O_EXCL, S_IREAD | S_IWRITE);
+      fd = open (template, O_RDWR | O_CREAT | O_EXCL, S_IRUSR | S_IWUSR);
 #endif
     }
   while (fd == -1 && errno == EEXIST);