]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ftrace: Add cond_resched() to ftrace_graph_set_hash()
authorzhoumin <teczm@foxmail.com>
Mon, 31 Mar 2025 17:00:34 +0000 (01:00 +0800)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 2 Apr 2025 13:51:25 +0000 (09:51 -0400)
When the kernel contains a large number of functions that can be traced,
the loop in ftrace_graph_set_hash() may take a lot of time to execute.
This may trigger the softlockup watchdog.

Add cond_resched() within the loop to allow the kernel to remain
responsive even when processing a large number of functions.

This matches the cond_resched() that is used in other locations of the
code that iterates over all functions that can be traced.

Cc: stable@vger.kernel.org
Fixes: b9b0c831bed26 ("ftrace: Convert graph filter to use hash tables")
Link: https://lore.kernel.org/tencent_3E06CE338692017B5809534B9C5C03DA7705@qq.com
Signed-off-by: zhoumin <teczm@foxmail.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/ftrace.c

index 92015de6203d1e90549852b2f84eaf9b4589b12f..1a48aedb52552a1f23c946b547ef15ef582eebe6 100644 (file)
@@ -6855,6 +6855,7 @@ ftrace_graph_set_hash(struct ftrace_hash *hash, char *buffer)
                                }
                        }
                }
+               cond_resched();
        } while_for_each_ftrace_rec();
 
        return fail ? -EINVAL : 0;