]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: Intel: sof_sdw: Fix unlikely uninitialized variable use in create_sdw_dailinks()
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Mon, 3 Mar 2025 06:55:52 +0000 (14:55 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 3 Mar 2025 13:03:08 +0000 (13:03 +0000)
Initialize current_be_id to 0 to handle the unlikely case when there are
no devices connected to a DAI.
In this case create_sdw_dailink() would return without touching the passed
pointer to current_be_id.

Found by gcc -fanalyzer

Fixes: 59bf457d8055 ("ASoC: intel: sof_sdw: Factor out SoundWire DAI creation")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://patch.msgid.link/20250303065552.78328-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/sof_sdw.c

index c13064c77726158c1715d0ff49808200a040d549..90dafa810b2ec0cec6f8cfad6f4ef0671f135ba4 100644 (file)
@@ -954,7 +954,7 @@ static int create_sdw_dailinks(struct snd_soc_card *card,
 
        /* generate DAI links by each sdw link */
        while (sof_dais->initialised) {
-               int current_be_id;
+               int current_be_id = 0;
 
                ret = create_sdw_dailink(card, sof_dais, dai_links,
                                         &current_be_id, codec_conf);