]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
qemu-bridge-helper: Document known shortcomings
authorMarkus Armbruster <armbru@redhat.com>
Tue, 4 Jun 2019 11:52:21 +0000 (13:52 +0200)
committerJason Wang <jasowang@redhat.com>
Tue, 2 Jul 2019 02:21:06 +0000 (10:21 +0800)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
qemu-bridge-helper.c

index f9940deefd53f5c82c288061b1f0496bdc9def6e..95624bc30055b9b5628e6cf495989b0f2ebb66d3 100644 (file)
  *
  * This work is licensed under the terms of the GNU GPL, version 2.  See
  * the COPYING file in the top-level directory.
- *
+ */
+
+/*
+ * Known shortcomings:
+ * - There is no manual page
+ * - The syntax of the ACL file is not documented anywhere
+ * - parse_acl_file() doesn't report fopen() failure properly, fails
+ *   to check ferror() after fgets() failure, arbitrarily truncates
+ *   long lines, handles whitespace inconsistently, error messages
+ *   don't point to the offending file and line, errors in included
+ *   files are reported, but otherwise ignored, ...
  */
 
 #include "qemu/osdep.h"