]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
fgraph: Make pid_str size match the comment
authorArtem Sadovnikov <a.sadovnikov@ispras.ru>
Tue, 17 Jun 2025 15:21:09 +0000 (15:21 +0000)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Thu, 10 Jul 2025 00:39:00 +0000 (20:39 -0400)
The comment above buffer mentions sign, 10 bytes width for number and null
terminator, but buffer itself isn't large enough to hold that much data.

This is a cosmetic change, since PID cannot be negative, other than -1.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Link: https://lore.kernel.org/20250617152110.2530-1-a.sadovnikov@ispras.ru
Signed-off-by: Artem Sadovnikov <a.sadovnikov@ispras.ru>
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_functions_graph.c

index 14d74a7491b8cb1bfcb0205aa175d8b401e7ae70..66e1a527cf1acdde7b27d29354440a8060484f5c 100644 (file)
@@ -513,7 +513,7 @@ static void print_graph_proc(struct trace_seq *s, pid_t pid)
 {
        char comm[TASK_COMM_LEN];
        /* sign + log10(MAX_INT) + '\0' */
-       char pid_str[11];
+       char pid_str[12];
        int spaces = 0;
        int len;
        int i;