]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/imx/dcss: Use IRQF_NO_AUTOEN flag in request_irq()
authorJinjie Ruan <ruanjinjie@huawei.com>
Thu, 12 Sep 2024 08:30:17 +0000 (16:30 +0800)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sat, 21 Sep 2024 20:48:15 +0000 (23:48 +0300)
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.

Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240912083020.3720233-3-ruanjinjie@huawei.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/imx/dcss/dcss-dtg.c

index 2968f5d5bd412e2276f8724de8e0a49ea786fcc5..6bbfd9aa27aca4b468847fc7bf8a1222dfd85d25 100644 (file)
@@ -134,14 +134,12 @@ static int dcss_dtg_irq_config(struct dcss_dtg *dtg,
                    dtg->base_reg + DCSS_DTG_INT_MASK);
 
        ret = request_irq(dtg->ctxld_kick_irq, dcss_dtg_irq_handler,
-                         0, "dcss_ctxld_kick", dtg);
+                         IRQF_NO_AUTOEN, "dcss_ctxld_kick", dtg);
        if (ret) {
                dev_err(dtg->dev, "dtg: irq request failed.\n");
                return ret;
        }
 
-       disable_irq(dtg->ctxld_kick_irq);
-
        dtg->ctxld_kick_irq_en = false;
 
        return 0;