]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: imx: imx7_mipi_csis: convert some switch cases to the default
authorTom Rix <trix@redhat.com>
Mon, 31 May 2021 17:43:00 +0000 (19:43 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 4 Aug 2021 12:43:51 +0000 (14:43 +0200)
Static analysis reports this false positive
imx7-mipi-csis.c:1027:2: warning: 4th function call argument is
  an uninitialized value

The variable 'align' is falsely reported as uninitialized.
Even though all the cases are covered in the
switch (csis_fmt->width % 8) {

Because there is no default case, it is reported as uninialized.

Improve the switch by converting the most numerous set of cases
to the default and silence the false positive.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/imx/imx7-mipi-csis.c

index ead696eb46103d320f803737430e70fecb8933d3..41e33535de552a62e38d78b454f8f2630cbe05de 100644 (file)
@@ -1019,10 +1019,8 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *sd,
        case 6:
                align = 2;
                break;
-       case 1:
-       case 3:
-       case 5:
-       case 7:
+       default:
+               /* 1, 3, 5, 7 */
                align = 3;
                break;
        }