]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
* Do not change the status code after we already sent it to the client.
authorRuediger Pluem <rpluem@apache.org>
Thu, 9 Dec 2021 07:40:25 +0000 (07:40 +0000)
committerRuediger Pluem <rpluem@apache.org>
Thu, 9 Dec 2021 07:40:25 +0000 (07:40 +0000)
  Changing the status code after we sent it to the client causes a status
  code being logged that is different from the one sent to the client which
  can be confusing.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1895715 13f79535-47bb-0310-9956-ffa450edef68

modules/proxy/mod_proxy_connect.c
modules/proxy/mod_proxy_http.c

index 7e503e3322a38db789ffc74a50a6e5ff65f7ccef..12b72a54c923406dcfd2895123215338d72b6ebb 100644 (file)
@@ -354,8 +354,6 @@ static int proxy_connect_handler(request_rec *r, proxy_worker *worker,
         if (proxyport && !tunnel->replied) {
             return rc;
         }
-        /* Custom log may need this, still */
-        r->status = rc;
     }
 
     /*
index c729220f3b739873b840cb25ade55b59db83cfcb..91be06fc12158905c644d4094370fcb55f0fc5aa 100644 (file)
@@ -1539,9 +1539,6 @@ int ap_proxy_http_process_response(proxy_http_req_t *req)
             /* Let proxy tunnel forward everything within this thread */
             req->tunnel->timeout = req->idle_timeout;
             status = ap_proxy_tunnel_run(req->tunnel);
-            if (ap_is_HTTP_ERROR(status)) {
-                r->status = status;
-            }
 
             /* Report bytes exchanged by the backend */
             backend->worker->s->read +=