drm/ttm: warn stricter about freeing pinned BOs

So far we only warned when the BOs where pinned and not idle.

Also warn if we see a pinned BO in general.

Signed-off-by: Christian König <christian.koenig@amd.com>
Acked-by: Leo Liu <leo.liu@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210415084730.2057-3-christian.koenig@amd.com

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index cfd0b929239734b3a0dd998ebf70d9f1fd31fc2c..80831df0ef6197fd4a11d6e70c62ae08b1902bce 100644 (file)
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -401,6 +401,8 @@ static void ttm_bo_release(struct kref *kref)
        struct ttm_device *bdev = bo->bdev;
        int ret;
 
+       WARN_ON_ONCE(bo->pin_count);
+
        if (!bo->deleted) {
                ret = ttm_bo_individualize_resv(bo);
                if (ret) {
@@ -434,7 +436,7 @@ static void ttm_bo_release(struct kref *kref)
                 * FIXME: QXL is triggering this. Can be removed when the
                 * driver is fixed.
                 */
-               if (WARN_ON_ONCE(bo->pin_count)) {
+               if (bo->pin_count) {
                        bo->pin_count = 0;
                        ttm_bo_move_to_lru_tail(bo, &bo->mem, NULL);
                }