]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
Correctly copy the target host identification in PQcancelCreate.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 2 Jul 2025 19:47:59 +0000 (15:47 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 2 Jul 2025 19:47:59 +0000 (15:47 -0400)
PQcancelCreate failed to copy struct pg_conn_host's "type" field,
instead leaving it zero (a/k/a CHT_HOST_NAME).  This seemingly
has no great ill effects if it should have been CHT_UNIX_SOCKET
instead, but if it should have been CHT_HOST_ADDRESS then a
null-pointer dereference will occur when the cancelConn is used.

Bug: #18974
Reported-by: Maxim Boguk <maxim.boguk@gmail.com>
Author: Sergei Kornilov <sk@zsrv.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/18974-575f02b2168b36b3@postgresql.org
Backpatch-through: 17

src/interfaces/libpq/fe-cancel.c

index 213a6f43c2d76e4e71346dddff86a86a9b54c70c..8c7aff42b5a54705e97e1e631a7cf7d2f130a410 100644 (file)
@@ -119,6 +119,7 @@ PQcancelCreate(PGconn *conn)
                goto oom_error;
 
        originalHost = conn->connhost[conn->whichhost];
+       cancelConn->connhost[0].type = originalHost.type;
        if (originalHost.host)
        {
                cancelConn->connhost[0].host = strdup(originalHost.host);